Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-135401: Test AWS-LC as a cryptography library in CI#135402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
WillChilds-Klein wants to merge21 commits intopython:main
base:main
Choose a base branch
Loading
fromWillChilds-Klein:add-awslc-ci-job

Conversation

WillChilds-Klein
Copy link
Contributor

@WillChilds-KleinWillChilds-Klein commentedJun 11, 2025•
edited
Loading

Notes

Currently in draft status to test the new workflow. Building AWS-LC, linking the interpreter to it dynamically, and running thessl tests all appear to work fine. I'm still working on remaining issues intest_hmac.

TODO

@AA-TurnerAA-Turner changed the titlegh-135401 Add AWS-LC-backed ssl module CI jobgh-135401: Test AWS-LC SSL in CIJun 11, 2025
with:
path: ./multissl/aws-lc/${{ matrix.awslc_ver }}
key: ${{ matrix.os }}-multissl-aws-lc-${{ matrix.awslc_ver }}
# TODO [childw] can we use env.* instead of env vars here?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd suggest for the initial version, keep as similar to the OpenSSL job/workflow, and then perhaps update both at once afterwards?

WillChilds-Klein reacted with thumbs up emoji
Copy link
ContributorAuthor

@WillChilds-KleinWillChilds-KleinJun 11, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fair enough. I'll remove the TODOs. Perhaps we can leave this comment unresolved as a reminder for me to clean up both (if tenable) if/after this PR has been merged.

WillChilds-Kleinand others added3 commitsJune 11, 2025 18:15
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
…XmL.rstCo-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@WillChilds-KleinWillChilds-Klein changed the titlegh-135401: Test AWS-LC SSL in CIgh-135401: Test AWS-LC as a cryptography library in CIJun 11, 2025
@picnixz
Copy link
Member

Can you cherry-pick8f4a0eb and make a separate PR please? TiA.

WillChilds-Klein reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments

@picnixzpicnixzAwaiting requested review from picnixzpicnixz is a code owner

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead will be requested when the pull request is marked ready for reviewgpshead is a code owner

@tirantiranAwaiting requested review from tirantiran will be requested when the pull request is marked ready for reviewtiran is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland will be requested when the pull request is marked ready for reviewerlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 will be requested when the pull request is marked ready for reviewcorona10 is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti will be requested when the pull request is marked ready for reviewezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk will be requested when the pull request is marked ready for reviewhugovk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@WillChilds-Klein@picnixz@AA-Turner
[8]ページ先頭
©2009-2025 Movatter.jp