Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-134262: Catch both URLError and ConnectionError in retries#135365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-134262: Catch both URLError and ConnectionError in retries#135365
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Uh oh!
There was an error while loading.Please reload this page.
…yping/cpython into catch-urlerror-and-connectionerror
acc20a8 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@emmatyping for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…ythonGH-135365)(cherry picked from commitacc20a8)Co-authored-by: Emma Smith <emma@emmatyping.dev>
GH-135611 is a backport of this pull request to the3.14 branch. |
Uh oh!
There was an error while loading.Please reload this page.
@StanFromIreland pointed to this failurehttps://github.com/python/cpython/actions/runs/15565936921/job/43829935370?pr=135355 where we fail downloading without useful debug information because we are only catching URLError. We should probably catch both URLError and ConnectionError for both of these retries so that we retry on all connection failures.