Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
GH-132661: Addstring.templatelib.convert()
#135217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There's some test failures here.@hugovk Would it be okay if we backported this to 3.14? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's just addstring.templatelib.convert
in this PR and leave docs for the big docs PR that currently in review.
Yes, this makes sense to be part of the PEP 750 stuff. RC1 is soon: 2025-07-22. |
@AA-Turner Are you going to work on this to simplify it down to just adding |
Yes, sorry (at EuroPython). Hopefully will have time this afternoon. A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! Thanks@AA-Turner!
5b969fd
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@AA-Turner for the PR, and@lysnikolaou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
(cherry picked from commit5b969fd)Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
GH-136671 is a backport of this pull request to the3.14 branch. |
davepeck commentedJul 15, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🎉 Thanks,@AA-Turner ! I'll add docs for this to#135229 |
Uh oh!
There was an error while loading.Please reload this page.
Seehttps://discuss.python.org/t/94569/. cc@davepeck@treyhunner.
Sketch implementation. Skip news as this would be part of the larger PEP 750 piece.
A
📚 Documentation preview 📚:https://cpython-previews--135217.org.readthedocs.build/