Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

parser_generator.py typo - keywods -> keywords#135014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 2 commits intopython:mainfromchemelnucfin:patch-1
Jul 19, 2025

Conversation

chemelnucfin
Copy link
Contributor

Pull Request title

Trivial changes, like fixing a typo, do not need an issue.

Typo in comment

@python-cla-bot
Copy link

python-cla-botbot commentedJun 2, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Copy link

@auvipyauvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

right work, but you also need to sign the cla and use skipnews

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@chemelnucfin
Copy link
ContributorAuthor

right work, but you also need to sign the cla and use skipnews

I believe skipnews should be added by maintainers? I signed the cla.

Should I keep updating the branch or can someone just merge this trivial PR? Thanks.

@johnzhou721
Copy link
Contributor

johnzhou721 commentedJun 3, 2025•
edited
Loading

Need someone to apply skip news and skip issue. Merging main into the branch or rebasing on top of main doesn't do harm but is unnessacary.

*EDIT-- as long as there are no conflicts.

@hugovk
Copy link
Member

Mergingmain is only needed if there's a conflict, or it's been a very long time and we want to check the CI still passes. Unnecessary merges uses up CI resources and pings those involved -- so this could be considered harm.

Anyway, thanks for the PR, let's merge!

@hugovkhugovk merged commitf520f22 intopython:mainJul 19, 2025
56 checks passed
@miss-islington-app
Copy link

Thanks@chemelnucfin for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 19, 2025
(cherry picked from commit f520f229271d55201a090f48faf1aa6f087d7608)Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 19, 2025
(cherry picked from commitf520f22)Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
@bedevere-app
Copy link

GH-136772 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJul 19, 2025
@bedevere-app
Copy link

GH-136773 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJul 19, 2025
hugovk pushed a commit that referenced this pull requestJul 19, 2025
…36773)Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
hugovk pushed a commit that referenced this pull requestJul 19, 2025
…36772)Co-authored-by: chemelnucfin <3982092+chemelnucfin@users.noreply.github.com>
omerpresler pushed a commit to omerpresler/cpython that referenced this pull requestJul 19, 2025
omerpresler pushed a commit to omerpresler/cpython that referenced this pull requestJul 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@auvipyauvipyauvipy approved these changes

@Wulian233Wulian233Wulian233 approved these changes

@johnzhou721johnzhou721johnzhou721 approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@chemelnucfin@johnzhou721@hugovk@auvipy@Wulian233@StanFromIreland
[8]ページ先頭
©2009-2025 Movatter.jp