Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-135004: rewrite and cleanupblake2module.c#135006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
_blake2module.cblake2module.c!buildbot FIPS |
bedevere-bot commentedJun 1, 2025
🤖 New build scheduled with the buildbot fleet by@picnixz for commit17365bd 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135006%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
bedevere-bot commentedJun 1, 2025
🤖 New build scheduled with the buildbot fleet by@picnixz for commit4b4b66c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135006%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
- use this new helper in `py_blake2b_get_digest_size`- in the future, exposing `key_length` will be easier
4b4b66c toce0e848CompareUh oh!
There was an error while loading.Please reload this page.
70ea98e tob16e301Compare3cb1097 intopython:mainUh oh!
There was an error while loading.Please reload this page.
* Cleanup imports and update module docstring.* Simplify detection of SIMD support.* Correctly guard `update()` cases.* Rewrite `py_blake2b_or_s_new` and rename it to `py_blake2_new`.* Rewrite `blake2_blake2b_copy_locked` and `py_blake2_clear`.* Refactor computations of `digest` and `hexdigest`.* Simplify `py_blake2b_get_name` and `py_blake2b_get_block_size`.* Add `hacl_get_blake2_info` to extract static BLAKE-2 information. This new helper is used by `py_blake2b_get_digest_size`, but can be later used to expose `key_length` more easily.
Uh oh!
There was an error while loading.Please reload this page.
Strictly speaking, we're gaining a bit as well:
I've updated
hmacmodule.cas well so that my two functions for detecting SIMD features have the same body. I could have a separate header, but it's easier that way (ideally, I'd like to rely on#125022 for SIMD detection in the future).blake2module.c#135004