Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
Fixzipfile._Extra.split
#134999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Fixzipfile._Extra.split
#134999
Conversation
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please make an issue.
The instruction says:
I think this fix is obvious and trivial enough that an extra issue is overkill. |
We need issues for actual bugs. They aren't needed for things like documentation changes. |
danny0838 commentedJun 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I don't know what should be put in the issue body. The original code is a bad design and may cause an issue if someone extends the |
Not disagreeing, but in practice, people will just fix that on the fly. It's typically not worth it to prematurely fix internal APIs. I'm going to leave this one up to@jaraco who wrote the code. |
As a class method, it should call from
cls
instead of_Extra
.