Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixzipfile._Extra.split#134999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
danny0838 wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromdanny0838:fix-zipfile-extra

Conversation

danny0838
Copy link

As a class method, it should call fromcls instead of_Extra.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please make an issue.

@danny0838
Copy link
Author

The instruction says:

Trivial changes, like fixing a typo, do not need an issue.

I think this fix is obvious and trivial enough that an extra issue is overkill.

@ZeroIntensity
Copy link
Member

We need issues for actual bugs. They aren't needed for things like documentation changes.

@danny0838
Copy link
Author

danny0838 commentedJun 3, 2025
edited
Loading

I don't know what should be put in the issue body.

The original code is a bad design and may cause an issue if someone extends the_Extra class, but it does not cause an actual bug so far as_Extra is only used internally.

@ZeroIntensity
Copy link
Member

The original code is a bad design and may cause an issue if someone extends the _Extra class, but it does not cause an actual bug so far as _Extra is only used internally.

Not disagreeing, but in practice, people will just fix that on the fly. It's typically not worth it to prematurely fix internal APIs.

I'm going to leave this one up to@jaraco who wrote the code.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ZeroIntensityZeroIntensityZeroIntensity left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@danny0838@ZeroIntensity

[8]ページ先頭

©2009-2025 Movatter.jp