Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-134875: Fix mimallc build error for the old compilers#134994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -634,10 +634,10 @@ static inline mi_block_t* mi_block_nextx( const void* null, const mi_block_t* bl | |||
| mi_track_mem_defined(block,sizeof(mi_block_t)); | |||
| mi_block_t* next; | |||
| #ifdef MI_ENCODE_FREELIST | |||
| next = (mi_block_t*)mi_ptr_decode(null, mi_atomic_load_relaxed(&block->next), keys); | |||
| next = (mi_block_t*)mi_ptr_decode(null, mi_atomic_load_relaxed((_Atomic(mi_encoded_t)*)&block->next), keys); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
block is declared asconst mi_block_t* block, so this issue happens. other way is to change the function signature, but I don't prefer it.
@corona10 Thank you, I can confirm that this fixes the compilation error. |
Let's wait@colesbury before merging this PR. Thanks for the verification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
b525e31 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…ngh-134994)(cherry picked from commitb525e31)Co-authored-by: Donghee Na <donghee.na@python.org>
GH-135053 is a backport of this pull request to the3.14 branch. |
Thanks@corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…ngh-134994)(cherry picked from commitb525e31)Co-authored-by: Donghee Na <donghee.na@python.org>
GH-135054 is a backport of this pull request to the3.13 branch. |
Uh oh!
There was an error while loading.Please reload this page.