NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

[3.14] gh-133968: Add PyUnicodeWriter_WriteASCII() function (#133973)#134974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

vstinner wants to merge1 commit intopython:3.14

base:3.14

Choose a base branch

fromvstinner:write_ascii14

Open

[3.14] gh-133968: Add PyUnicodeWriter_WriteASCII() function (#133973)#134974

vstinner wants to merge1 commit intopython:3.14fromvstinner:write_ascii14

+98 −32

Conversation

Copy link

Member

vstinner commentedMay 31, 2025•
edited by github-actionsbot
Loading

Replace most PyUnicodeWriter_WriteUTF8() calls with PyUnicodeWriter_WriteASCII().

Unrelated change to please the linter: remove an unused import in test_ctypes.

(cherry picked from commitf49a07b)

Issue:Using the public PyUnicodeWriter C API made the json module slower #133968

📚 Documentation preview 📚:https://cpython-previews--134974.org.readthedocs.build/

pythongh-133968: Add PyUnicodeWriter_WriteASCII() function (python#13…

1dc045c

…3973)Replace most PyUnicodeWriter_WriteUTF8() calls withPyUnicodeWriter_WriteASCII().Unrelated change to please the linter: remove an unusedimport in test_ctypes.Co-authored-by: Peter Bierma <zintensitydev@gmail.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>(cherry picked from commitf49a07b)

vstinner requested review fromisidentical,JelleZijlstra,Eclips4,gpshead,picnixz,markshannon and1st1 ascode owners

May 31, 2025 11:30

bedevere-appbot mentioned this pull request

May 31, 2025

Using the public PyUnicodeWriter C API made the json module slower#133968

Open

bedevere-appbot added the awaiting core review label

May 31, 2025

bedevere-appbot mentioned this pull request

May 31, 2025

gh-133968: Add PyUnicodeWriter_WriteASCII() function#133973

Merged

Copy link

MemberAuthor

vstinner commentedMay 31, 2025

@hugovk: Hi, can I have an exception to add this late feature into Python 3.14 after the feature freeze? It was decided late but it comes with thePyUnicodeWriter which was just added to Python 3.14.

This change fix also a performance regression compared to Python 3.13:Using the public PyUnicodeWriter C API made the json module slower.

@zooba wrote:

I'd check with the RM about adding it to 3.14 as well. I suspect it should be okay - there's no compatibility impact, and it'll save introducing one by having to choose a different API between 3.14/3.15.