Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
[3.13] gh-134696: align OpenSSL and HACL*-based hash functions constructors AC signatures (GH-134713)#134962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+868 −439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…constructors AC signatures (pythonGH-134713)OpenSSL and HACL*-based hash functions constructors now support both `data` and `string` parameters.Previously these constructor functions inconsistently supported sometimes `data` and sometimes `string`,while the documentation expected `data` to be given in all cases.(cherry picked from commitc6e63d9)(cherry picked from commit379d0bc)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
bedevere-bot commentedMay 31, 2025
🤖 New build scheduled with the buildbot fleet by@picnixz for commitad4c913 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134962%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
2c325e2 intopython:3.13 113 of 115 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
OpenSSL and HACL*-based hash functions constructors now support both
dataandstringparameters. Previously these constructor functions inconsistently supported sometimesdataand sometimesstring, while the documentation expecteddatato be given in all cases.(cherry picked from commitc6e63d9 and379d0bc)