All commit authors signed the Contributor License Agreement.

There are similar cases on lines 117, 154 and 155. Would you mind fixing them too?

The original intent was to differentiate betweenTrue (the singular value) and something that's "truthy" (that is, it evaluates toTrue in a boolean context. I'd like to avoid "If true (the default isTrue)", but I suppose it's more correct.

All of the ones that were changed to "IfTrue (the default isFalse)" should instead be left alone. "If true (the default isFalse)" is correct.

Hi@ericvsmith 👋 , thanks for the clarification.

if I understood correctly, then there is only one occurrence to be changed:

unsafe_hash: IfFalse (the default)
to
unsafe_hash: If false (the default)

Is this correct?

unsafe_hash: IfFalse (the default)

I think the correct change is: if false (the default isFalse). The default value ofunsafe_hash is booleanFalse. "false" means something that evaluates toFalse in a boolean context.

Note: I already have an open PR for this:#116532 (although not taking the same approach).

Maybe they should all be rewritten so that they describe the behavior if the flag is set, not ever if the flag has a "falsy" value. Then at the end, put the default value. So they'd all become something like "If true, then <whatever>. The default value isTrue". Or "If true, then <whatever>. The default value isFalse." Or maybe omit the default values entirely, they're given immediately above.

At this point I suggest someone from the documentation group take a look, or just leave it as it is.

I don't this PR adds anything, would suggest closing.

A