Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134923: Use /GENPROFILE and /USEPROFILE for Windows PGO builds#134924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 1 commit intopython:mainfromzooba:gh-134923
May 30, 2025

Conversation

zooba
Copy link
Member

@zoobazooba commentedMay 30, 2025•
edited by bedevere-appbot
Loading

@zoobazooba requested a review froma team as acode ownerMay 30, 2025 10:03
@bedevere-appbedevere-appbot mentioned this pull requestMay 30, 2025
@zoobazooba added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes and removed awaiting core review labelsMay 30, 2025
@zooba
Copy link
MemberAuthor

There's a test release running athttps://dev.azure.com/Python/cpython/_build/results?buildId=162238&view=results, as CI doesn't enable PGO.

@zooba
Copy link
MemberAuthor

Test release was good, so I think this is good to go.

@mdboom FYI, in case this might affect your benchmarking.

@mdboom
Copy link
Contributor

I'll kick off a benchmarking run of this PR right now to confirm no negative impact.

@mdboom
Copy link
Contributor

I'll kick off a benchmarking run of this PR right now to confirm no negative impact.

Theresults are here. Less than 0.01% slower overall, so "within the noise".

@zooba
Copy link
MemberAuthor

Good to know, thanks! From the docs it sounds like if anything, the time it takes to collect the profile is improved, but we don't really care too much about that anyway.

@zoobazooba merged commit8865b4f intopython:mainMay 30, 2025
49 checks passed
@miss-islington-app
Copy link

Thanks@zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@zoobazooba deleted the gh-134923 branchMay 30, 2025 18:37
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 30, 2025
…ds (pythonGH-134924)(cherry picked from commit8865b4f)Co-authored-by: Steve Dower <steve.dower@python.org>
@miss-islington-app
Copy link

Sorry,@zooba, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 8865b4f95b32097099d252111669b88ec7c1eb7f 3.13

@bedevere-app
Copy link

GH-134950 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 30, 2025
@bedevere-app
Copy link

GH-134951 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 30, 2025
zooba added a commit that referenced this pull requestMay 30, 2025
…-134924)(cherry picked from commit8865b4f)Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mdboommdboommdboom approved these changes

Assignees

@zoobazooba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@zooba@mdboom
[8]ページ先頭
©2009-2025 Movatter.jp