NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

[3.14] gh-134768: Fix definition of`mt_continue_should_break()` (GH-134769)#134916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gpshead merged 1 commit intopython:3.14frommiss-islington:backport-2f2bee2-3.14

May 30, 2025

Merged

[3.14] gh-134768: Fix definition of`mt_continue_should_break()` (GH-134769)#134916

gpshead merged 1 commit intopython:3.14frommiss-islington:backport-2f2bee2-3.14

May 30, 2025

Conversation

Copy link

Contributor

miss-islington commentedMay 30, 2025•
edited by bedevere-appbot
Loading

In121ed71, mt_continue_should_break
was changed to be guarded byPy_DEBUG, but it's used incompress_mt_continue_lock_held
with justassert, so it needs to be available whenNDEBUG is undefined
too.

Py_DEBUG impliesNDEBUG is undefined, so we can check just that.
(cherry picked from commit2f2bee2)

Co-authored-by: Sam Jamessam@gentoo.org
Fixes:121ed71

Issue:Build failure on main and latest Python 3.14 beta (missing mt_continue_should_break) #134768

pythongh-134768: Fix definition ofmt_continue_should_break()(pyth…

b3b34c8

…onGH-134769)In121ed71, mt_continue_should_breakwas changed to be guarded by `Py_DEBUG`, but it's used in `compress_mt_continue_lock_held`with just `assert`, so it needs to be available when `NDEBUG` is undefinedtoo.`Py_DEBUG` implies `NDEBUG` is undefined, so we can check just that.(cherry picked from commit2f2bee2)Co-authored-by: Sam James <sam@gentoo.org>Fixes:121ed71