Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-91048: Reorder result tuple of parse_code_object#134898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+42 −42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The standard followed by APIs like pstat.Stats is to take a file, line,function triplet. The parse_code_object function (and callers exposingthis in Python like RemoteUnwinder.get_stack_trace) return function,file, line triplets which requires the caller to reorder these whenusing it in classes like pstat.Stats.
pablogsal approved these changesMay 31, 2025
8e8786f intopython:main 48 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@lkollar for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 31, 2025
…34898)Reorder result tuple of parse_code_objectThe standard followed by APIs like pstat.Stats is to take a file, line,function triplet. The parse_code_object function (and callers exposingthis in Python like RemoteUnwinder.get_stack_trace) return function,file, line triplets which requires the caller to reorder these whenusing it in classes like pstat.Stats.(cherry picked from commit 8e8786f8986353e20c1c4406c34409a6139fa073)Co-authored-by: László Kiss Kollár <kiss.kollar.laszlo@gmail.com>
GH-134956 is a backport of this pull request to the3.14 branch. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The standard followed by APIs like pstat.Stats is to take a file, line, function triplet. The parse_code_object function (and callers exposing this in Python like RemoteUnwinder.get_stack_trace) return function, file, line triplets which requires the caller to reorder these when using it in classes like pstat.Stats.