Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-134679: Fix assertion failure in QSBR#134811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
colesbury merged 1 commit intopython:mainfromcolesbury:gh-134679-qsbr-poll
May 27, 2025

Conversation

colesbury
Copy link
Contributor

@colesburycolesbury commentedMay 27, 2025
edited by bedevere-appbot
Loading

This is the same underlying bug asgh-130519. The destructor may call arbitrary code, changing thetstate->qsbr pointer and invalidating the old_qsbr_thread_state.

This is the same underlying bug aspythongh-130519. The destructor may callarbitrary code, changing the tstate->qsbr pointer and invalidating theold _qsbr_thread_state.
@colesbury
Copy link
ContributorAuthor

Tested by running./python -m test test_free_threading.test_dict in a loop with TSan enabled. TSan seems to help reproduce the bug, probably because it slows a lot of things down.

@colesburycolesbury merged commita4d37f8 intopython:mainMay 27, 2025
49 checks passed
@colesburycolesbury deleted the gh-134679-qsbr-poll branchMay 27, 2025 20:21
@miss-islington-app
Copy link

Thanks@colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 27, 2025
This is the same underlying bug aspythongh-130519. The destructor may callarbitrary code, changing the `tstate->qsbr pointer` and invalidating theold `struct _qsbr_thread_state`.(cherry picked from commita4d37f8)Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

GH-134814 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 27, 2025
colesbury added a commit that referenced this pull requestMay 27, 2025
This is the same underlying bug asgh-130519. The destructor may callarbitrary code, changing the `tstate->qsbr pointer` and invalidating theold `struct _qsbr_thread_state`.(cherry picked from commita4d37f8)Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 CentOS9 NoGIL Refleaks 3.x (tier-1) has failed when building commita4d37f8.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1610/builds/1486) and take a look at the build logs.
  4. Check if the failure is related to this commit (a4d37f8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1610/builds/1486

Failed tests:

  • test.test_concurrent_futures.test_thread_pool

Failed subtests:

  • test_free_reference - test.test_concurrent_futures.test_thread_pool.ThreadPoolExecutorTest.test_free_reference

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.itamaro-centos-aws.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line220, intest_free_referencefor _in support.sleeping_retry(support.SHORT_TIMEOUT):~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.itamaro-centos-aws.refleak.nogil/build/Lib/test/support/__init__.py", line2590, insleeping_retryfor _in busy_retry(timeout, err_msg,error=error):~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.x.itamaro-centos-aws.refleak.nogil/build/Lib/test/support/__init__.py", line2560, inbusy_retryraiseAssertionError(msg)AssertionError:timeout (68.3 seconds)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mpagempagempage approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@colesbury@bedevere-bot@mpage

[8]ページ先頭

©2009-2025 Movatter.jp