Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-131798: Optimize_ITER_CHECK_TUPLE#134803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

noamcohen97
Copy link
Contributor

@noamcohen97noamcohen97 commentedMay 27, 2025
edited by bedevere-appbot
Loading

Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, thanks! Normally we want to add a test verifying the optimization is working too. However, this is a special case --- just to let you know how the tracer currently works, we trace from backwards jumps. Once we see a for loop, we try "closing" the loop. Thus, we would never see_ITER_CHECK_TUPLE except for a nested for loop. However, since the inner loop will always warm up before the outer loop, it will be hard to extract the real trace we want to inspect.

In short, your testing code might look like this:

for i in range(WARMUP):    for x in (1,2,3):        pass

but that will generate 2 JIT executors, not just 1, so it will cause us some issues when trying to identify the jitted code.

This is more of a side ramble about the limitations of our testing infrastructure, nothing you can do to fix it till we fix the testing on our side.

@noamcohen97
Copy link
ContributorAuthor

Thanks@Fidget-Spinner and@tomasr8 for reviewing

@Fidget-SpinnerFidget-Spinner merged commit79d81f7 intopython:mainMay 27, 2025
54 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tomasr8tomasr8tomasr8 left review comments

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@noamcohen97@tomasr8@Fidget-Spinner

[8]ページ先頭

©2009-2025 Movatter.jp