Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
[3.14] GH-134774: fix 'Py_DEBUG': macro redefinition warnings for Windows debug builds#134791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Sorry for the other PR: I've messed up and immediately closed again. So sorry for the churn but I never did a PR against something else than main before. Had to get 3.14 into my fork since when I've created it some time ago I chose the recommended "only main branch" option. This seems correct now, but cannot do anything more regarding the other PR than immediately closing :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This code exists in main. Should not we start with main?
The removed lines were just erroneously part of the backport#134211 and belong to a different issue#131942 which is "good" on main. Neither main nor 3.13, etc, are affected. Only 3.14. See also#134774 (comment):
|
| /* _DEBUG implies Py_DEBUG */ | ||
| #ifdef_DEBUG | ||
| # definePy_DEBUG 1 | ||
| #endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Isn't this the one we want to keep? The earlier definition is the new one, to fix an issue with.lib selection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh I see, the rest of that change didn't get backported. This is fine
6c74700 intopython:3.14Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Since PR#134211 / issue#133779 was packported to 3.14, Windows debug builds show more than thousand such warnings:
This stems from
cpython/PC/pyconfig.h
Lines 97 to 100 inb6e624a
which got added in the above PR, but rather belong to PR#131944 / issue#131942 and should just be deleted.