Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
[3.13] gh-132710: only use stable_uuid.generate_time_safe() to deduce MAC address (GH-132901)#134704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:3.13
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…to deduce MAC address (pythonGH-132901)(cherry picked from commit3bffada)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
| @@ -572,22 +572,24 @@ def _netstat_getnode(): | |||
| try: | |||
| import _uuid | |||
| _generate_time_safe = getattr(_uuid, "generate_time_safe", None) | |||
| _has_stable_extractable_node = _uuid.has_stable_extractable_node | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| _has_stable_extractable_node=_uuid.has_stable_extractable_node | |
| _has_stable_extractable_node=getattr(_uuid,"has_stable_extractable_node",False) |
This failed downstream inastral-sh/python-build-standalone#634, I think you need to usegetattr as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(though maybe something else weird is going on)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hum, that's weird. The _uuid module should unconditionally have the attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's what I thought from reading the patch too. I didn't dig deeper though, since this worked around the failing test.
Once this is merged, I'll need to incorporate#135226 as well. |
Uh oh!
There was an error while loading.Please reload this page.
(cherry picked from commit3bffada)
An additional NEWS entry will be needed (I forgot to do it for the other twos, so I'll add a NEWS entry for 3.15 and 3.14 in a separate PR, and when this PR needs to be merged, then I'll add it as well)
libuuid#132710