Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.13] fix: removeast.MatchStar.name class-level default value (gh-134674)#134681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

hunterhogan
Copy link
Contributor

I inappropriately submitted this to the main branch in pull request#134676, which is now closed.

Fixesgh-134674

Problem

ast.MatchStar.name incorrectly appears to have a class-level default value when usingast.dump(). The issue causesast.MatchStar(name=None) to display asMatchStar() instead of the expectedMatchStar(name=None).

Solution

Change the ASDL definition ofMatchStar, and addMatchStar to the special cases list inast.dump() alongsideConstant andMatchSingleton.

@picnixz
Copy link
Member

  • Why was this opened against 3.13? is it 3.13 only?
  • If not, please checkout frommain and open a PR against main. We will make the backports if needed.
hunterhogan reacted with confused emoji

@hunterhogan
Copy link
ContributorAuthor

  • Why was this opened against 3.13? is it 3.13 only?

  • If not, please checkout frommain and open a PR against main. We will make the backports if needed.

I inappropriately submitted this to the main branch in pull request#134676, which is now closed.

@picnixz
Copy link
Member

picnixz commentedMay 26, 2025
edited
Loading

Yes, but why was it submitted incorrectly? all PRs should be opened against main. AFAICT, the other PR was based from 3.13 and not main. Or is the issue only in 3.13?

@hunterhogan
Copy link
ContributorAuthor

Yes, but why was it submitted incorrectly? all PRs must be opened against main. afaict, the other PR was based from 3.13 and not main. Or is the issue only in 3.13?

#134676 (comment)

Why? I am diligently trying to follow instructions.

I am a little frustrated that you are asking me questions that are certainly answered in the first pull request or in the Issue.

I cannot do this the right way if I don't understand what the right way is.

@picnixz
Copy link
Member

picnixz commentedMay 26, 2025
edited
Loading

that are certainly answered in the first pull request or in the Issue

I can't find in the issue whether the issue is 3.13 only or not. If it's a 3.13 issue, then it's fine, but AFAICT, the current behaviors between 3.13 and 3.15 look the same. For that reason, 3.13, 3.14 and 3.15 are affected by this issue and thus we should fix 3.15 (which is main) and then we backport the changes to 3.14 and 3.13 (this is how it's done).

@picnixz
Copy link
Member

picnixz commentedMay 26, 2025
edited
Loading

#134676 (comment)

This comment was perhaps incomplete but the idea was to:

  • Checkout frommain
  • Make the changes.
  • Open a PR against main.

It would have been fine to checkout from 3.13, make the changes and open a PR against 3.13only if the bug is present in 3.13 but not in 3.14 or 3.15 (but AFAICT, this is not the case here)

@picnixz
Copy link
Member

And I apologize if I was rude, that wasn't my intention!

@hunterhogan
Copy link
ContributorAuthor

And I apologize if I was rude, that wasn't my intention!

Thank you very much for the additional information! I was confused. I sincerely hope I understand things well enough now to submit a well-formed pull request.

@picnixz
Copy link
Member

Don't worry, we'll go through together! It's 3:24 AM here so I'll be away but I'll definitely have a look at your PR. I'm sorry if I sounded rude with my questions that were maybe a bit too direct

@hunterhogan
Copy link
ContributorAuthor

It's all good. You believed I had as much knowledge as you have, which is a compliment to me because I barely understand git or this process for contributing to CPython.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@isidenticalisidenticalAwaiting requested review from isidenticalisidentical is a code owner

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees
No one assigned
Labels
awaiting reviewtopic-parsertype-bugAn unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hunterhogan@picnixz

[8]ページ先頭

©2009-2025 Movatter.jp