Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-131798: JIT: Assign type to sliced string/list/tuple#134671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
| // Slicing a string/list/tuple always returns the same type. | ||
| PyTypeObject *type = sym_get_type(container); | ||
| if (type == &PyUnicode_Type || | ||
| type == &PyList_Type || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| type==&PyList_Type|| | |
| type==&PyBytes_Type|| | |
| type==&PyList_Type|| |
I do not know whether slicing a bytes object occurs often enough to addPyBytes_Type here (and whether the jit slows down if we add more cases here), but if I understand correctly slicingbytes (orbytearray) results in abytes (orbytearray) so we could add them.
Slicing a string/list/tuple always returns the same type.
Make the optimizer assign a string/list/tuple type to the result of slicing a string/list/tuple.
@brandtbucher