Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134635: addzlib.{adler32,crc32}_combine to combine checksums#134650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 10 commits intopython:mainfrompicnixz:feat/zlib/crc32-combine-134635
May 27, 2025

Conversation

picnixz
Copy link
Member

@picnixzpicnixz commentedMay 25, 2025•
edited by github-actionsbot
Loading

Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Have a few suggestions/thoughts but overall looks great!

@picnixz
Copy link
MemberAuthor

Thanks for the feedback! I'm not on my dev session so I won't be able to change the clinic-related code as I'll need to regen the files, but I'll address the rest in the meantime.

emmatyping reacted with thumbs up emoji

picnixzand others added3 commitsMay 25, 2025 17:34
Copy link
Contributor

@thatchthatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall looks good, thanks!

@picnixzpicnixzforce-pushed thefeat/zlib/crc32-combine-134635 branch fromaa8b941 toc5a2c55CompareMay 26, 2025 09:03
@picnixz
Copy link
MemberAuthor

Thanks for the reviews both of you!

Copy link
Member

@emmatypingemmatyping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Two suggestions for wording but otherwise looks great! Thank you for adding these.

Co-authored-by: Emma Smith <emma@emmatyping.dev>
Copy link
MemberAuthor

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've edited your suggestion a bit but thank you!

emmatyping reacted with thumbs up emoji
@picnixzpicnixz self-assigned thisMay 26, 2025
@picnixzpicnixz merged commit737b4ba intopython:mainMay 27, 2025
39 checks passed
@picnixzpicnixz deleted the feat/zlib/crc32-combine-134635 branchMay 27, 2025 08:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@emmatypingemmatypingemmatyping approved these changes

@thatchthatchthatch approved these changes

Assignees

@picnixzpicnixz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@picnixz@thatch@emmatyping
[8]ページ先頭
©2009-2025 Movatter.jp