Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-119180: Updates to PEP 649/749 docs#134640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Mention (again) that `type.__annotations__` is unsafe. It is now safe when using only classes defined under PEP 649 semantics, but not with classes defined using `from __future__ import annotations`.- Mention that annotations on instances no longer work. There was already an issue about this.- Mention the general changes in the "Porting to Python 3.14" section.- `annotationlib` was proposed by PEP-749, not PEP-649.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One minor suggestion which you can take or leave, but otherwise looks good.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Emma Smith <emma@emmatyping.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@JelleZijlstra. I made a small suggestion for readability.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
7291eab intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
- Mention (again) that `type.__annotations__` is unsafe. It is now safe when using only classes defined under PEP 649 semantics, but not with classes defined using `from __future__ import annotations`.- Mention that annotations on instances no longer work. There was already an issue about this.- Mention the general changes in the "Porting to Python 3.14" section.- `annotationlib` was proposed by PEP-749, not PEP-649.(cherry picked from commit7291eab)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Emma Smith <emma@emmatyping.dev>Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
GH-134731 is a backport of this pull request to the3.14 branch. |
gh-119180: Updates to PEP 649/749 docs (GH-134640)- Mention (again) that `type.__annotations__` is unsafe. It is now safe when using only classes defined under PEP 649 semantics, but not with classes defined using `from __future__ import annotations`.- Mention that annotations on instances no longer work. There was already an issue about this.- Mention the general changes in the "Porting to Python 3.14" section.- `annotationlib` was proposed byPEP-749, notPEP-649.(cherry picked from commit7291eab)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Emma Smith <emma@emmatyping.dev>Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Uh oh!
There was an error while loading.Please reload this page.
type.__annotations__is unsafe. It is now safewhen using only classes defined under PEP 649 semantics, but not with
classes defined using
from __future__ import annotations.an issue about this.
annotationlibwas proposed byPEP-749, notPEP-649.📚 Documentation preview 📚:https://cpython-previews--134640.org.readthedocs.build/