Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-134632: Fixbuild-details.json to useINCLUDEPY path#134633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Fix ``build-details.json`` generation to use ``INCLUDEPY``, in order toreference the ``pythonX.Y`` subdirectory of the include directory, asrequired in :pep:`739`, instead of the top-level include directory.
CC@FFY00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
| reference the ``pythonX.Y`` subdirectory of the include directory, as | ||
| required in :pep:`739`, instead of the top-level include directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If required by the PEP, we should have a test enforcing this contract?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you have anything specific in mind? Checking that the value in the generatedbuild-details.json ends withpythonX.Y specifically, or something deeper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've added a test that checks that the values ofc_api.include andc_api.pkgconfig_path (if present) point to valid directories with necessary files.
Uh oh!
There was an error while loading.Please reload this page.
Fix
build-details.jsongeneration to useINCLUDEPY, in order to reference thepythonX.Ysubdirectory of the include directory, as required inPEP-0739, instead of the top-level include directory.build-details.json:c_api.headersdoes not include thepythonX.Ydirectory #134632