Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-133579: correctly report C curses errors in_curses_panel#134629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@picnixz
Copy link
Member

@picnixzpicnixz commentedMay 24, 2025
edited
Loading

This was part of#125844 but I extracted it from there because it wasn't necessary. I'll make it part ofgh-133579 instead ofgh-125843 because the other one was more for curses module itself and this one is a follow-up (and also because I changed some exception types)

@picnixzpicnixz requested a review fromencukouMay 24, 2025 12:26
@picnixzpicnixz changed the titlegh-125843: correctly report C curses errors in_curses_panelgh-133579: correctly report C curses errors in_curses_panelMay 24, 2025
@picnixzpicnixz requested a review fromvstinnerMay 30, 2025 13:57
@encukou
Copy link
Member

Looks good! Sorry for the delay.
Let's merge if the buildbots don't complain.

@encukouencukou added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJun 6, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@encukou for commite6c00d0 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134629%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJun 6, 2025
Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Buildbot failures are unrelated.
I don't mind keeping the comment in. Do you really want to remove it?

@picnixz
Copy link
MemberAuthor

picnixz commentedJun 7, 2025
edited
Loading

Do you really want to remove it?

Not really, though I think I can remove it if we go through all modules that don't correctly assert this (but in a follow-up). In practice, I don't think it'll be an issue as such functions are internal-only, so issues would be caught at review time. We could do more expensive checks on DEBUG builds though.

I think I wanted to remove it because I expected that this issue was already well-known and that my comment could have been "too much".

@picnixzpicnixz self-assigned thisJun 7, 2025
@encukou
Copy link
Member

So let's merge this as is?
(You just assigned yourself, does that mean you want to do something more?)

@picnixz
Copy link
MemberAuthor

(You just assigned yourself, does that mean you want to do something more?)

I assign the PR to myself when I want to merge it later, otherwise I forget about the PR. But if you want to merge it before, you can go ahead!

@picnixz
Copy link
MemberAuthor

Also, I myself only merge stuff when I'm on Linux as I can revert or make a fast patch if something breaks just after (I'm currently on Windows since I'm playing). So usually I merge my PRs when I'm back on Linux.

@picnixzpicnixz merged commitd610f11 intopython:mainJun 8, 2025
117 of 127 checks passed
@picnixzpicnixz deleted the fix/curses/panel-better-errors-125843 branchJune 8, 2025 07:10
@encukou
Copy link
Member

I assign the PR to myself when I want to merge it later, otherwise I forget about the PR.

Ah, got it! I'll try to remember that for later :)

Also, I myself only merge stuff when I'm on Linux as I can revert or make a fast patch if something breaks just after (I'm currently on Windows since I'm playing).

No rush. Myself, I'm only back to Linuxnow.
(Feel free to turn off GitHub notifications when playing; it's perfectly OK to reply a day or two later.)

lkollar pushed a commit to lkollar/cpython that referenced this pull requestJun 19, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull requestJul 12, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull requestAug 4, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull requestAug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@encukouencukouencukou approved these changes

@vstinnervstinnerAwaiting requested review from vstinner

Assignees

@picnixzpicnixz

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnixz@encukou@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp