Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-133579: correctly report C curses errors in_curses_panel#134629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
picnixz wants to merge8 commits intopython:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
_curses_panel_curses_panelpicnixz commentedMay 30, 2025
Comment on lines +49 to +59
| /* | ||
| * Note: 'state' may be NULL if Py_TYPE(panel) is not a heap | ||
| * type associated with this module, but the compiler would | ||
| * have likely already complained with an "invalid pointer | ||
| * type" at compile-time. | ||
| * | ||
| * To make it more robust, all functions recovering a module's | ||
| * state from an object should expect to return NULL with an | ||
| * exception set (in contrast to functions recovering a module's | ||
| * state from a module itself). | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll remove this comment once reviewers have seen it.
picnixz commentedMay 30, 2025
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This was part of#125844 but I extracted it from there because it wasn't necessary. I'll make it part ofgh-133579 instead ofgh-125843 because the other one was more for curses module itself and this one is a follow-up (and also because I changed some exception types)
cursesC function failures #133579