Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-133579: correctly report C curses errors in_curses_panel#134629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-133579: correctly report C curses errors in_curses_panel#134629
Uh oh!
There was an error while loading.Please reload this page.
Conversation
_curses_panel_curses_panelUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
encukou commentedJun 6, 2025
Looks good! Sorry for the delay. |
bedevere-bot commentedJun 6, 2025
🤖 New build scheduled with the buildbot fleet by@encukou for commite6c00d0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134629%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
encukou left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Buildbot failures are unrelated.
I don't mind keeping the comment in. Do you really want to remove it?
picnixz commentedJun 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Not really, though I think I can remove it if we go through all modules that don't correctly assert this (but in a follow-up). In practice, I don't think it'll be an issue as such functions are internal-only, so issues would be caught at review time. We could do more expensive checks on DEBUG builds though. I think I wanted to remove it because I expected that this issue was already well-known and that my comment could have been "too much". |
encukou commentedJun 7, 2025
So let's merge this as is? |
picnixz commentedJun 7, 2025
I assign the PR to myself when I want to merge it later, otherwise I forget about the PR. But if you want to merge it before, you can go ahead! |
picnixz commentedJun 7, 2025
Also, I myself only merge stuff when I'm on Linux as I can revert or make a fast patch if something breaks just after (I'm currently on Windows since I'm playing). So usually I merge my PRs when I'm back on Linux. |
d610f11 intopython:mainUh oh!
There was an error while loading.Please reload this page.
encukou commentedJun 9, 2025
Ah, got it! I'll try to remember that for later :)
No rush. Myself, I'm only back to Linuxnow. |
…ython#134629)This is a follow-up toee36db5.
…ython#134629)This is a follow-up toee36db5.
…ython#134629)This is a follow-up toee36db5.
…ython#134629)This is a follow-up toee36db5.
Uh oh!
There was an error while loading.Please reload this page.
This was part of#125844 but I extracted it from there because it wasn't necessary. I'll make it part ofgh-133579 instead ofgh-125843 because the other one was more for curses module itself and this one is a follow-up (and also because I changed some exception types)
cursesC function failures #133579