Movatterモバイル変換

Skip to content

python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-109934: notify cancelled futures on thread pool shutdown#134618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

duaneg wants to merge1 commit intopython:main

base:main

Choose a base branch

fromduaneg:gh-109934

Open

gh-109934: notify cancelled futures on thread pool shutdown#134618

duaneg wants to merge1 commit intopython:mainfromduaneg:gh-109934

+53 −0

Conversation

duaneg

Copy link

Contributor

duaneg commentedMay 24, 2025•
edited by bedevere-appbot
Loading

WhenThreadPoolExecutor shuts down it cancels any pending futures, however at present it doesn't notify waiters. Thus their state stays asCANCELLED instead ofCANCELLED_AND_NOTIFIED and any waiters are not awakened.

Callset_running_or_notify_cancel on the cancelled futures to fix this.

Issue:concurrent.futures.wait returns cancelled as "not done" #109934

@duaneg

pythongh-109934: notify cancelled futures on thread pool shutdown

8040f9a

When `ThreadPoolExecutor` shuts down it cancels any pending futures, however atpresent it doesn't notify waiters. Thus their state stays as `CANCELLED`instead of `CANCELLED_AND_NOTIFIED` and any waiters are not awakened.Call `set_running_or_notify_cancel` on the cancelled futures to fix this.

@bedevere-app

bedevere-appbot mentioned this pull request

concurrent.futures.wait returns cancelled as "not done"#109934

Open

@bedevere-app

bedevere-appbot added the awaiting review label

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

awaiting review

1 participant

@duaneg

[8]ページ先頭

©2009-2025 Movatter.jp