Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132983: Make _zstd C code PEP 7 compliant#134605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 3 commits intopython:mainfromemmatyping:zstd-format-pep7
May 24, 2025

Conversation

emmatyping
Copy link
Member

@emmatypingemmatyping commentedMay 24, 2025•
edited by bedevere-appbot
Loading

Mostly just making sure things are under 80 characters and fixing a few incorrectly placed left braces. I also removedconst from instances of_zstd_state* const mod_state since a) it was making some lines go over 80 characters b) it is unnecessary and c) it better matches the CPython style.

This is the final todo left in#132983 🎉

gpshead reacted with hooray emoji
@gpsheadgpshead merged commit973b8f6 intopython:mainMay 24, 2025
42 checks passed
@miss-islington-app
Copy link

Thanks@emmatyping for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 24, 2025
Make _zstd C code PEP 7 compliant(cherry picked from commit973b8f6)Co-authored-by: Emma Smith <emma@emmatyping.dev>
@bedevere-app
Copy link

GH-134609 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 24, 2025
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Windows Server 2022 NoGIL 3.x (tier-1) has failed when building commit973b8f6.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1241/builds/5870) and take a look at the build logs.
  4. Check if the failure is related to this commit (973b8f6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1241/builds/5870

Failed tests:

  • test_weakref
  • test_venv

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):Traceback (most recent call last):  File"C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_venv.py", line616, intest_multiprocessing    out, err= check_output([self.envpy(real_env_dir=True),'-c',~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^'from multiprocessing import Pool;'^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^'pool = Pool(1);'^^^^^^^^^^^^^^^^^^'print(pool.apply_async("Python".lower).get(3));'^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^'pool.terminate()'])^^^^^^^^^^^^^^^^^^^^  File"C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_venv.py", line58, incheck_outputraise subprocess.CalledProcessError(        p.returncode, cmd, out, err)subprocess.CalledProcessError:Command '['C:\\Users\\Administrator\\AppData\\Local\\Temp\\test_python_oln4cn7v\\tmp5x1oqj4y\\Scripts\\python3.15t_d.exe', '-c', 'from multiprocessing import Pool; pool = Pool(1); print(pool.apply_async("Python".lower).get(3)); pool.terminate()']' returned non-zero exit status 1.

gpshead pushed a commit that referenced this pull requestMay 24, 2025
)gh-132983: Make _zstd C code PEP 7 compliant (GH-134605)Make _zstd C code PEP 7 compliant(cherry picked from commit973b8f6)Co-authored-by: Emma Smith <emma@emmatyping.dev>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gpsheadgpsheadgpshead approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@emmatyping@bedevere-bot@gpshead
[8]ページ先頭
©2009-2025 Movatter.jp