May 23, 2025 · May 23, 2025 · May 25, 2025 · Jun 7, 2025 · May 23, 2025 · May 25, 2025
diff --git a/Lib/test/test_gettext.py b/Lib/test/test_gettext.py
 importunittest
 importunittest.mock
 fromfunctoolsimportpartial
 importtempfile
 importshutil

 fromtestimportsupport
 fromtest.supportimportcpython_only,os_helper
 fromtest.support.import_helperimportensure_lazy_imports


 # TODO:
 #  - Add new tests, for example for "dgettext"
 #  - Tests should have only one assert.

 GNU_MO_DATA=b'''\
 ensure_lazy_imports("gettext", {"re","warnings","locale"})


 classDGettextTest(unittest.TestCase):
 """Test dgettext() function, which allows translations from specific domains."""

 defsetUp(self):
 """Set up a specific test domain and environment for dgettext tests."""
 self.localedir=tempfile.mkdtemp()
 self.addCleanup(shutil.rmtree,self.localedir)
 self.domain='gettext_domain'
 self.mofile=self.setup_dgettext_test_env()

 defsetup_dgettext_test_env(self):
 """Create a mo file for dgettext testing."""
 os.makedirs(os.path.join(self.localedir,'en','LC_MESSAGES'),exist_ok=True)
 mofile=os.path.join(self.localedir,'en','LC_MESSAGES',f'{self.domain}.mo')
 withopen(mofile,'wb')asfp:
 fp.write(b'\x00\x00\x00\x00')
 returnmofile

 deftest_dgettext_found_translation(self):
 """Test dgettext finds translation in specified domain."""
 gettext.bindtextdomain(self.domain,self.localedir)
 withunittest.mock.patch('gettext.dgettext')asmock_dgettext:
 mock_dgettext.return_value='test message translation'
 result=gettext.dgettext(self.domain,'test message')
 self.assertEqual(result,'test message translation')

 deftest_dgettext_missing_translation(self):
 """Test dgettext returns msgid when translation is missing."""
 gettext.bindtextdomain(self.domain,self.localedir)
 result=gettext.dgettext(self.domain,'missing message')
 self.assertEqual(result,'missing message')

 deftest_dgettext_non_existent_domain(self):
 """Test dgettext returns msgid when domain doesn't exist."""
 result=gettext.dgettext('nonexistent_domain','test message')
 self.assertEqual(result,'test message')

 deftest_dgettext_empty_domain(self):
 """Test dgettext behavior with empty domain."""
 current_domain=gettext.textdomain()
 result=gettext.dgettext('','test message')
 expected=gettext.gettext('test message')
 self.assertEqual(result,expected)


 if__name__=='__main__':
 unittest.main()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -4,14 +4,15 @@
		importunittest
		importunittest.mock
		fromfunctoolsimportpartial
		importtempfile
		importshutil

		fromtestimportsupport
		fromtest.supportimportcpython_only,os_helper
		fromtest.support.import_helperimportensure_lazy_imports


		# TODO:
		# - Add new tests, for example for "dgettext"
Copy link Member StanFromIrelandMay 25, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Let's keep the TODO, since it is still valid (the first part). It can be updated with the issue number if you wish.
		# - Tests should have only one assert.

		GNU_MO_DATA=b'''\
Expand DownExpand Up		@@ -937,6 +938,51 @@ def test_lazy_import(self):
		ensure_lazy_imports("gettext", {"re","warnings","locale"})


		classDGettextTest(unittest.TestCase):
		"""Test dgettext() function, which allows translations from specific domains."""

		defsetUp(self):
		"""Set up a specific test domain and environment for dgettext tests."""
		self.localedir=tempfile.mkdtemp()
Copy link Member picnixzMay 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Instead of using`mkdtemp` which would create something inside`/tmp`, use`test.support.temp_dir` (I think, check the name) which creates something inside the build folder (it's easier to cleanup)
		self.addCleanup(shutil.rmtree,self.localedir)
Copy link Member picnixzMay 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Prefer using`os_helper.rmtree` over`shutil.rmtree`
		self.domain='gettext_domain'
		self.mofile=self.setup_dgettext_test_env()

		defsetup_dgettext_test_env(self):
		"""Create a mo file for dgettext testing."""
		os.makedirs(os.path.join(self.localedir,'en','LC_MESSAGES'),exist_ok=True)
		mofile=os.path.join(self.localedir,'en','LC_MESSAGES',f'{self.domain}.mo')
		withopen(mofile,'wb')asfp:
		fp.write(b'\x00\x00\x00\x00')
		returnmofile

		deftest_dgettext_found_translation(self):
Copy link Member StanFromIrelandMay 25, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Join this one with the other two, these all test the exact same thing (which is well tested above too).
		"""Test dgettext finds translation in specified domain."""
Copy link Member picnixzMay 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Avoid using docstrings for`test_*` methods as it will be shown upon failure.
		gettext.bindtextdomain(self.domain,self.localedir)
		withunittest.mock.patch('gettext.dgettext')asmock_dgettext:
		mock_dgettext.return_value='test message translation'
		result=gettext.dgettext(self.domain,'test message')
		self.assertEqual(result,'test message translation')

		deftest_dgettext_missing_translation(self):
		"""Test dgettext returns msgid when translation is missing."""
		gettext.bindtextdomain(self.domain,self.localedir)
		result=gettext.dgettext(self.domain,'missing message')
		self.assertEqual(result,'missing message')

		deftest_dgettext_non_existent_domain(self):
		"""Test dgettext returns msgid when domain doesn't exist."""
		result=gettext.dgettext('nonexistent_domain','test message')
		self.assertEqual(result,'test message')

		deftest_dgettext_empty_domain(self):
		"""Test dgettext behavior with empty domain."""
		current_domain=gettext.textdomain()
		result=gettext.dgettext('','test message')
		expected=gettext.gettext('test message')
		self.assertEqual(result,expected)


		if__name__=='__main__':
		unittest.main()

Expand Down