Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134381: Improve thread safety in _PyThread_AfterFork by preserving not-started handles#134514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
colesbury merged 8 commits intopython:mainfromzangjiucheng:gh-134381-main
May 23, 2025

Conversation

zangjiucheng
Copy link
Contributor

@zangjiuchengzangjiucheng commentedMay 22, 2025•
edited
Loading

@python-cla-bot
Copy link

python-cla-botbot commentedMay 22, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you add a test for this? Something like the repro in the issue is probably fine.

zangjiucheng reacted with thumbs up emoji
@zangjiucheng
Copy link
ContributorAuthor

Could you add a test for this? Something like the repro in the issue is probably fine.

I did add a similar test case, but not sure if that's good enough to cover the issue similar to the issue mentioned. Please take a review.

@colesburycolesbury added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 22, 2025
Copy link
Contributor

@colesburycolesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tests looks good. Some comments about how to structure it in the multiprocessing test suite below.

Copy link
Contributor

@colesburycolesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the fix, LGTM

zangjiucheng reacted with heart emoji
@colesburycolesbury added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMay 23, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@colesbury for commitca06d61 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134514%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMay 23, 2025
@colesburycolesbury self-assigned thisMay 23, 2025
Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tiny little formatting suggestion.

@colesburycolesbury merged commit9a2346d intopython:mainMay 23, 2025
39 checks passed
@miss-islington-app
Copy link

Thanks@zangjiucheng for the PR, and@colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 23, 2025
…d after fork (pythongh-134514)(cherry picked from commit9a2346d)Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 23, 2025
…d after fork (pythongh-134514)(cherry picked from commit9a2346d)Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
@bedevere-app
Copy link

GH-134596 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 23, 2025
@bedevere-app
Copy link

GH-134597 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 23, 2025
colesbury pushed a commit that referenced this pull requestMay 23, 2025
…ad after fork (gh-134514) (gh-134597)(cherry picked from commit9a2346d)Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
colesbury pushed a commit that referenced this pull requestMay 23, 2025
…ad after fork (gh-134514) (gh-134596)(cherry picked from commit9a2346d)Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@colesburycolesburycolesbury approved these changes

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

Assignees

@colesburycolesbury

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@zangjiucheng@bedevere-bot@colesbury@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp