All commit authors signed the Contributor License Agreement.

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@sobolevn can you see, please?

Do we usehash /eq /gt or something with this class?

No, dataclass was used to just avoid manually writing__init__.

Thanks@RenameMe1 for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

GH-134564 is a backport of this pull request to the3.14 branch.

Oh, never mind - these were just my small nitpicks :)
Thanks,@RenameMe1!

I think this change was a mistake, and should be rolled back. A better, more compatible change would be to make it a non-frozen dataclass.

@ericvsmith can you please explain why? Did we miss some extra dataclass-generated methods? Or isfields() used somewhere on instances of this type?

Because we don't know everywhere it's used. Why take the chance of breaking things? I think it's a good idea to make the smallest possible change to fix the problem, and that would be an unfrozen dataclass.

I've broken plenty of things over the years with similar small changes. We should be very careful with any change.

@ericvsmith I think that it is fine, it was added 3 weeks ago2bc8365#diff-2aec630227e154e015d98ccdb65d86f6ad365e1d029bbe6289933b7ad41b69f3R17 and I think that people did not have time to really use it and attach to small implementation details. In my opinion, it is a right time for this change.

But, I am open for other opinions / reverting this, if there are actual things that we broke 🤝

I didn't realize it was new. In that case, I'm mostly okay with it. But since it's after Beta 1, you might want to check with the Release Manager.

cc@hugovk

Thanks, I think this is fine.