Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134451: Delete@dataclass forasyncio.tools.CycleFoundException class#134513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 4 commits intopython:mainfromRenameMe1:fix-issue-134451
May 23, 2025

Conversation

RenameMe1
Copy link
Contributor

@RenameMe1RenameMe1 commentedMay 22, 2025•
edited by bedevere-appbot
Loading

@python-cla-bot
Copy link

python-cla-botbot commentedMay 22, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@RenameMe1
Copy link
ContributorAuthor

@sobolevn can you see, please?

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we use__hash__ /__eq__ /__gt__ or something with this class?

Co-authored-by: sobolevn <mail@sobolevn.me>
@kumaraditya303kumaraditya303enabled auto-merge (squash)May 23, 2025 04:50
@kumaraditya303kumaraditya303 added the needs backport to 3.14bugs and security fixes labelMay 23, 2025
@kumaraditya303
Copy link
Contributor

Do we usehash /eq /gt or something with this class?

No, dataclass was used to just avoid manually writing__init__.

@sobolevnsobolevn changed the titlegh-134451: Deleted @dataclass forasyncio.tools. CycleFoundException classgh-134451: Delete@dataclass forasyncio.tools.CycleFoundException classMay 23, 2025
@kumaraditya303kumaraditya303 merged commitf9324cb intopython:mainMay 23, 2025
45 checks passed
@miss-islington-app
Copy link

Thanks@RenameMe1 for the PR, and@kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 23, 2025
…ataclass to a regular exception type. (pythonGH-134513)(cherry picked from commitf9324cb)Co-authored-by: Evgeny Demchenko <v1mpire@icloud.com>
@bedevere-app
Copy link

GH-134564 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 23, 2025
@sobolevn
Copy link
Member

Oh, never mind - these were just my small nitpicks :)
Thanks,@RenameMe1!

kumaraditya303 pushed a commit that referenced this pull requestMay 23, 2025
…dataclass to a regular exception type. (GH-134513) (#134564)gh-134451: Converted `asyncio.tools.CycleFoundException` from dataclass to a regular exception type. (GH-134513)(cherry picked from commitf9324cb)Co-authored-by: Evgeny Demchenko <v1mpire@icloud.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sobolevnsobolevnsobolevn approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@RenameMe1@kumaraditya303@sobolevn
[8]ページ先頭
©2009-2025 Movatter.jp