Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134486: Fix missing alloca symbol in _ctypes on NetBSD.#134487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromcollinfunk:fix-alloca-definition
May 23, 2025

Conversation

collinfunk
Copy link
Contributor

@collinfunkcollinfunk commentedMay 22, 2025•
edited by bedevere-appbot
Loading

Previously the module would fail to load because thealloca symbol was undefined. Now we check for GCC/Clang builtins for systems who do not definealloca in headers.

furkanonder reacted with thumbs up emoji
@AA-Turner
Copy link
Member

!buildbot BSD

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@AA-Turner for commit46b0d9d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134487%2Fmerge

The command will test the builders whose names match following regular expression:BSD

The builders matched are:

  • AMD64 FreeBSD15 PR
  • AMD64 FreeBSD Refleaks PR
  • AMD64 FreeBSD14 PR
  • AMD64 FreeBSD PR

Copy link
Member

@ZeroIntensityZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, buildbot failure looks unrelated.

Previously the module would fail to load because the ``alloca`` symbolwas undefined. Now we check for GCC/Clang builtins for systems who donot define ``alloca`` in headers.
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link
Contributor

@furkanonderfurkanonder left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. The issue occurs onNetBSD 10.0 (ARM architecture). As a check, I tested the changes in the PR onNetBSD 10.0 (amd64) and got a successful build.

@vstinnervstinner merged commitb8f5526 intopython:mainMay 23, 2025
43 checks passed
@vstinner
Copy link
Member

Merged, thank you.

collinfunk reacted with thumbs up emoji

@collinfunkcollinfunk deleted the fix-alloca-definition branchMay 23, 2025 18:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments

@ZeroIntensityZeroIntensityZeroIntensity approved these changes

@vstinnervstinnervstinner approved these changes

@furkanonderfurkanonderfurkanonder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@collinfunk@AA-Turner@bedevere-bot@vstinner@furkanonder@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp