May 21, 2025 · May 21, 2025 · May 21, 2025 · May 21, 2025 · May 21, 2025 · May 21, 2025
diff --git a/Modules/_datetimemodule.c b/Modules/_datetimemodule.c
                                              tm.tm_mon + 1,
                                              tm.tm_mday,
                                              cls);
 if (date == NULL) {
    return NULL;
 }
 PyObject *result = NULL;
 if (date == NULL) {
    return NULL;
 }
 PyObject *result = NULL;
        PyObject *delta = new_delta(0, (int)t, 0, normalize);
 if (delta == NULL) {
    goto error;
 }
 result = add_date_timedelta(PyDate_CAST(date), PyDelta_CAST(delta), negate);
        if (delta == NULL) {
            Py_XDECREF(date);
            return NULL;
        }
        result = add_date_timedelta(PyDate_CAST(date), PyDelta_CAST(delta), negate);
        Py_XDECREF(delta);
    error:
        Py_XDECREF(date);
        return result;
    }
    if (timet < 0) {
        int normalize = 1, factor = 1;
        PyObject *dt = datetime_from_timet_and_us(cls, f, 0, 0, tzinfo);
 if (dt == NULL) {
    return NULL;
 }
 PyObject *result = NULL;
 if (dt == NULL) {
    return NULL;
 }
 PyObject *result = NULL;
        PyObject *delta = new_delta(0, (int)timet, us, normalize);
 if (delta == NULL) {
    goto error;
 }
        if (delta == NULL) {
            Py_XDECREF(dt);
            return NULL;
        }
        result = add_datetime_timedelta(PyDateTime_CAST(dt), PyDelta_CAST(delta), factor);
        Py_XDECREF(delta);
    error:
        Py_XDECREF(dt);
        return result;
    }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -3267,17 +3267,17 @@ date_fromtimestamp(PyObject cls, PyObject obj)
		tm.tm_mon + 1,
		tm.tm_mday,
		cls);
jhohm marked this conversation as resolved. Show resolvedHide resolved
		if (date == NULL) {
		return NULL;
		}
		PyObject *result = NULL;
		if (date == NULL) {
		return NULL;
		}
		PyObject *result = NULL;
		PyObject *delta = new_delta(0, (int)t, 0, normalize);
jhohm marked this conversation as resolved. Show resolvedHide resolved
		if (delta == NULL) {
		goto error;
		}
		result = add_date_timedelta(PyDate_CAST(date), PyDelta_CAST(delta), negate);
		if (delta == NULL) {
		Py_XDECREF(date);
		return NULL;
		}
Copy link Member vstinnerMay 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. You can move negate and result definitions here. There is no need to initialize result to NULL.
		result = add_date_timedelta(PyDate_CAST(date), PyDelta_CAST(delta), negate);
		Py_XDECREF(delta);
		error:
		Py_XDECREF(date);
jhohm marked this conversation as resolved. Show resolvedHide resolved
		return result;
		}
Expand DownExpand Up		@@ -5567,17 +5567,17 @@ datetime_from_timestamp(PyObject cls, TM_FUNC f, PyObject timestamp,
		if (timet < 0) {
		int normalize = 1, factor = 1;
		PyObject *dt = datetime_from_timet_and_us(cls, f, 0, 0, tzinfo);
		if (dt == NULL) {
		return NULL;
		}
		PyObject *result = NULL;
		if (dt == NULL) {
		return NULL;
		}
		PyObject *result = NULL;
		PyObject *delta = new_delta(0, (int)timet, us, normalize);
jhohm marked this conversation as resolved. Show resolvedHide resolved
		if (delta == NULL) {
		goto error;
		}
		if (delta == NULL) {
		Py_XDECREF(dt);
		return NULL;
		}
Copy link Member vstinnerMay 23, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. You can move result definition here. There is no need to initialize it to NULL.
		result = add_datetime_timedelta(PyDateTime_CAST(dt), PyDelta_CAST(delta), factor);
		Py_XDECREF(delta);
		error:
		Py_XDECREF(dt);
		return result;
		}
Expand Down