Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-80620: Support negative values infromtimestamp
on Windows using 0 +timedelta
#134461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
jhohm wants to merge14 commits intopython:mainChoose a base branch fromjhohm:gh-80620
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+79 −25
Open
Changes from1 commit
Commits
Show all changes
14 commits Select commitHold shift + click to select a range
6704876
Support negative values in `fromtimestamp` on Windows using 0 + `time…
jhohma3e5749
Fixes from actually building on Windows.
jhohm7453c3c
Support negative integer timestamps too; skip tests that would genera…
jhohm15c5520
Avoid double-adding microseconds in _pydatetime datetime.fromtimestamp.
jhohm329db66
Untabify _datetimemodule.c
jhohm34c999f
Free intermediate objects in _datetimemodule.
jhohm0dd521f
Reorder initialization to be consistent between added code.
jhohm44bcfd9
Handle all errors; switch to more common os.name == 'nt' check
jhohme675d63
Explain in news that negative timestamps are dates before the epoch.
jhohm02082f7
Fix OS check to import os.
jhohmcb2f911
Untabify; copy error handling code instead of goto.
jhohm057dd79
No need to XDECREF non-NULL objects.
jhohm5d9db9d
Reuse `fromtimestamp` for 0 values, and `timedelta()` instead of cast…
jhohm77a8b11
Merge branch 'main' into gh-80620
jhohmFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
PrevPrevious commit
Merge branch 'main' intogh-80620
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit77a8b11d34189fc92f0d0aaa816a5e531d7a6d1d
There are no files selected for viewing
This merge commit was added into this branch cleanly.
There are no new changes to show, but you can stillview the diff.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.