Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-132983: Fix refleak in zstd dictionary functions#134459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ericsnowcurrently merged 1 commit intopython:mainfromemmatyping:zstd-refleak
May 21, 2025

Conversation

emmatyping
Copy link
Member

@emmatypingemmatyping commentedMay 21, 2025•
edited by bedevere-appbot
Loading

Missed deallocating the array of samples sizes if an invalid array of samples are provided. h/t to@ericsnowcurrently for spotting the buildbot failure.

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@ericsnowcurrentlyericsnowcurrentlyenabled auto-merge (squash)May 21, 2025 18:52
@ericsnowcurrentlyericsnowcurrently merged commitfb68776 intopython:mainMay 21, 2025
48 checks passed
@miss-islington-app
Copy link

Thanks@emmatyping for the PR, and@ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 21, 2025
…34459)(cherry picked from commitfb68776)Co-authored-by: Emma Smith <emma@emmatyping.dev>
@bedevere-app
Copy link

GH-134463 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 21, 2025
ericsnowcurrently pushed a commit that referenced this pull requestMay 21, 2025
(cherry picked from commitfb68776, AKAgh-134459)Co-authored-by: Emma Smith <emma@emmatyping.dev>
@emmatypingemmatyping deleted the zstd-refleak branchMay 21, 2025 20:30
@gpshead
Copy link
Member

Hah, I even looked at the original PR for a dealloc, guess I also missed that case. ❤️

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

@gpsheadgpsheadAwaiting requested review from gpshead

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@emmatyping@gpshead@ericsnowcurrently
[8]ページ先頭
©2009-2025 Movatter.jp