Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134455: Fixbuild-details.json to use thec_api.headers key#134456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
FFY00 merged 2 commits intopython:mainfrommgorny:capi-headers-134455
May 22, 2025

Conversation

mgorny
Copy link
Contributor

@mgornymgorny commentedMay 21, 2025•
edited by bedevere-appbot
Loading

Fixbuild-details.json generation to use the correctc_api.headers key as defined in PEP 739, instead ofc_api.include.

…` keyFix `build-details.json` generation to use the correct `c_api.headers`key as defined in PEP 739, instead of `c_api.include`.
@mgorny
Copy link
ContributorAuthor

CC@FFY00

@mgorny
Copy link
ContributorAuthor

Apparently the standalone tool has the same problem, and someone already submitted a fix for it:FFY00/python-introspection#2

Copy link
Member

@FFY00FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@mgorny!

@FFY00
Copy link
Member

Apparently the standalone tool has the same problem, and someone already submitted a fix for it:FFY00/python-introspection#2

Yeah, that's the origin of the code I merged into CPython, so it tracks 😅

@FFY00FFY00enabled auto-merge (squash)May 22, 2025 10:53
@FFY00FFY00 merged commitd706eb9 intopython:mainMay 22, 2025
47 checks passed
@hugovk
Copy link
Member

And backport to 3.14?

FFY00 reacted with thumbs up emoji

@FFY00
Copy link
Member

Ah, yes, I was forgetting we already branched out. Thanks for the reminder@hugovk!

hugovk reacted with thumbs up emoji

@hugovkhugovk added the needs backport to 3.14bugs and security fixes labelMay 22, 2025
@miss-islington-app
Copy link

Thanks@mgorny for the PR, and@FFY00 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 22, 2025
…` key (pythonGH-134456)Fix `build-details.json` generation to use the correct `c_api.headers`key as defined in PEP 739, instead of `c_api.include`.(cherry picked from commitd706eb9)Co-authored-by: Michał Górny <mgorny@gentoo.org>Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
@bedevere-app
Copy link

GH-134504 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 22, 2025
hugovk pushed a commit that referenced this pull requestMay 22, 2025
…`` key (GH-134456) (#134504)Co-authored-by: Michał Górny <mgorny@gentoo.org>Co-authored-by: Filipe Laíns 🇵🇸 <lains@riseup.net>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@FFY00FFY00FFY00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mgorny@FFY00@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp