NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

[3.14] gh-133982: Run unclosed file test on all io implementations (gh-134165)#134433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ambv merged 1 commit intopython:3.14frommiss-islington:backport-5b0e827-3.14

May 21, 2025

Merged

[3.14] gh-133982: Run unclosed file test on all io implementations (gh-134165)#134433

ambv merged 1 commit intopython:3.14frommiss-islington:backport-5b0e827-3.14

May 21, 2025

Conversation

Copy link

Contributor

miss-islington commentedMay 21, 2025•
edited by bedevere-appbot
Loading

Updatetest_io_check_warn_on_dealloc to useself. to dispatch to
different I/O implementations.

Update the_pyio implementation to match expected behavior, using the
same_dealloc_warn design as the C implementation uses to report the
topmost__del__ object.

The FileIO one now matches all the others, so can use IOBase. There was
a missing check on closing (self._fd must be valid), add that check
(cherry picked from commit5b0e827)

Co-authored-by: Cody Maloneycmaloney@users.noreply.github.com

Issue:Use implemenation-specific I/O open / constructors in tests #133982

pythongh-133982: Run unclosed file test on all io implementations (py…

0b27e08

…thongh-134165)Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch todifferent I/O implementations.Update the `_pyio` implementation to match expected behavior, using thesame `_dealloc_warn` design as the C implementation uses to report thetopmost `__del__` object.The FileIO one now matches all the others, so can use IOBase. There wasa missing check on closing (self._fd must be valid), add that check(cherry picked from commit5b0e827)Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>

This was referencedMay 21, 2025

Use implemenation-specific I/O open / constructors in tests#133982

Open

gh-133982: Run unclosed file test on all io implementations#134165

Merged