Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100163: allow re-assuming root privileges on subprocess invocations#134400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
duaneg wants to merge4 commits intopython:main
base:main
Choose a base branch
Loading
fromduaneg:gh-100163
Draft
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
Allow :class:`subprocess.Popen` to run subprocesses as root after dropping
root privileges but saving the original user/group identity so it can be
re-assumed.
88 changes: 71 additions & 17 deletionsModules/_posixsubprocess.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -625,6 +625,76 @@ reset_signal_handlers(const sigset_t *child_sigmask)
#endif /* VFORK_USABLE */


static int set_user_identity(uid_t uid)
{
if (uid == (uid_t)-1)
return 0;
#if defined(HAVE_SETRESUID)
return setresuid(uid, uid, uid);
#elif defined(HAVE_SETREUID)
return setreuid(uid, uid);
#endif
return 0;
}


static int set_group_identity(gid_t gid)
{
if (gid == (gid_t)-1)
return 0;
#if defined(HAVE_SETRESGID)
return setresgid(gid, gid, gid);
#elif defined(HAVE_SETREGID)
return setregid(gid, gid);
#endif
return 0;
}


static int set_groups(Py_ssize_t extra_group_size, const gid_t *extra_groups)
{
#ifdef HAVE_SETGROUPS
if (extra_group_size >= 0) {
assert((extra_group_size == 0) == (extra_groups == NULL));
return setgroups(extra_group_size, extra_groups);
}
#endif /* HAVE_SETGROUPS */
return 0;
}


static int
set_identity_priv(uid_t uid, gid_t gid,
Py_ssize_t extra_group_size, const gid_t *extra_groups)
{
return (set_user_identity(uid)
|| set_group_identity(gid)
|| set_groups(extra_group_size, extra_groups)) ? -1 : 0;
}


static int
set_identity_unpriv(uid_t uid, gid_t gid,
Py_ssize_t extra_group_size, const gid_t *extra_groups)
{
return (set_groups(extra_group_size, extra_groups)
|| set_group_identity(gid)
|| set_user_identity(uid)) ? -1 : 0;
}


static int
set_identity(uid_t uid, gid_t gid,
Py_ssize_t extra_group_size, const gid_t *extra_groups)
{
if (uid == 0) {
return set_identity_priv(uid, gid, extra_group_size, extra_groups);
} else {
return set_identity_unpriv(uid, gid, extra_group_size, extra_groups);
}
}


/*
* This function is code executed in the child process immediately after
* (v)fork to set things up and call exec().
Expand DownExpand Up@@ -773,23 +843,7 @@ child_exec(char *const exec_array[],
}
#endif

#ifdef HAVE_SETGROUPS
if (extra_group_size >= 0) {
assert((extra_group_size == 0) == (extra_groups == NULL));
POSIX_CALL(setgroups(extra_group_size, extra_groups));
}
#endif /* HAVE_SETGROUPS */

#ifdef HAVE_SETREGID
if (gid != (gid_t)-1)
POSIX_CALL(setregid(gid, gid));
#endif /* HAVE_SETREGID */

#ifdef HAVE_SETREUID
if (uid != (uid_t)-1)
POSIX_CALL(setreuid(uid, uid));
#endif /* HAVE_SETREUID */

POSIX_CALL(set_identity(uid, gid, extra_group_size, extra_groups));

err_msg = "";
if (preexec_fn != Py_None && preexec_fn_args_tuple) {
Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp