Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-90871: fix connection backlog offset in asyncio#134392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 13 commits intopython:mainfromChristianHrs:gh-90871
May 21, 2025

Conversation

ChristianHrs
Copy link
Contributor

@ChristianHrsChristianHrs commentedMay 20, 2025•
edited by bedevere-appbot
Loading

ChristianHrsand others added11 commitsMay 20, 2025 15:06
…ted new tests for 0 and 1 connections"This reverts commit17d39e9.
…ions log once through the exception handler (pythongh-134331)"This reverts commitf695eca.
@kumaraditya303kumaraditya303 changed the titlegh-90871 - Fix connection backlog offsetgh-90871: fix connection backlog offset in asyncioMay 21, 2025
Copy link
Contributor

@kumaraditya303kumaraditya303 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As per FreeBSD docs andhttps://www.man7.org/linux/man-pages/man2/listen.2.html about backlog, this is correct.

ChristianHrs reacted with thumbs up emoji
@ambvambv merged commit109f759 intopython:mainMay 21, 2025
43 checks passed
@ambvambv added the needs backport to 3.14bugs and security fixes labelMay 21, 2025
@miss-islington-app
Copy link

Thanks@ChristianHrs for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 21, 2025
…4392)(cherry picked from commit109f759)Co-authored-by: Christian Harries <68507104+ChristianHrs@users.noreply.github.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

GH-134421 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 21, 2025
@ambvambv added the needs backport to 3.13bugs and security fixes labelMay 21, 2025
@miss-islington-app
Copy link

Thanks@ChristianHrs for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry,@ChristianHrs and@ambv, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 109f7597d29f0b504e9b42cb398b44177157abaa 3.13

@ambv
Copy link
Contributor

To backport to 3.13, we might consider backporting#127532 first.

ambv added a commit that referenced this pull requestMay 21, 2025
…gh-134421)(cherry picked from commit109f759)Co-authored-by: Christian Harries <68507104+ChristianHrs@users.noreply.github.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@ChristianHrsChristianHrs deleted the gh-90871 branchMay 21, 2025 19:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees

@ambvambv

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asyncio.create_unix_server has an off-by-one error concerning the backlog parameter
3 participants
@ChristianHrs@ambv@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp