NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

[3.14] gh-134209: use heap-allocated memory in`_curses.window.{instr,getstr}` (GH-134283)#134391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gpshead merged 1 commit intopython:3.14frommiss-islington:backport-aadda87-3.14

May 20, 2025

Merged

[3.14] gh-134209: use heap-allocated memory in`_curses.window.{instr,getstr}` (GH-134283)#134391

gpshead merged 1 commit intopython:3.14frommiss-islington:backport-aadda87-3.14

May 20, 2025

Conversation

Copy link

Contributor

miss-islington commentedMay 20, 2025•
edited by github-actionsbot
Loading

made curses buffer heap allocated instead of stack
change docs to explicitly mention the max buffer size
changing GetStr() function to behave similarly too
Update Doc/library/curses.rst
Update instr with proper return error handling
Update Modules/_cursesmodule.c
change to strlen and better memory safety
change from const int to Py_ssize_t
add mem allocation guard
update versionchanged to mention it was an increase.
explicitly use versionchanged 3.14 as that is its own branch now.

TESTED:python -m test -u curses test_curses

(cherry picked from commitaadda87)

Co-authored-by: tigerding43339228+zydtiger@users.noreply.github.com
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Gregory P. Smithgreg@krypto.org
Co-authored-by: Bénédikt Tran10796600+picnixz@users.noreply.github.com

Issue:Possible loss of large text data in_curses.window.{instr,getstr} #134209

📚 Documentation preview 📚:https://cpython-previews--134391.org.readthedocs.build/

pythongh-134209: use heap-allocated memory in `_curses.window.{instr,…

ab60ed5

…getstr}` (pythonGH-134283)* made curses buffer heap allocated instead of stack* change docs to explicitly mention the max buffer size* changing GetStr() function to behave similarly too* Update Doc/library/curses.rst* Update instr with proper return error handling* Update Modules/_cursesmodule.c* change to strlen and better memory safety* change from const int to Py_ssize_t* add mem allocation guard* update versionchanged to mention it was an increase.* explicitly use versionchanged 3.14 as that is its own branch now.TESTED: `python -m test -u curses test_curses`---------(cherry picked from commitaadda87)Co-authored-by: tigerding <43339228+zydtiger@users.noreply.github.com>Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>Co-authored-by: Gregory P. Smith <greg@krypto.org>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>