Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Remove Cirrus macOS runners from CI#134390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
hugovk wants to merge1 commit intopython:mainChoose a base branch fromhugovk:3.14-rm-cirrus
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+1 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a draft PR in case we need it during sprints. We can always revert after the sprints if necessary.
The Cirrus workers are much faster than GitHub ones. Here's the free-threaded job (from April), with config cache available.
Left isCirrus, 4m 16s total
RightGHA, 7m 54s total
The regular build is similar: Cirrus 4m 21s, GHA 6m 47s.
The Cirrus workers have 4 CPUs compared to GH's 3.
However, when things are very busy, like during the sprints, we're limited by the number of Cirrus workers available. I don't have a number but some runs today looked like this:
The blue lines are the normal limiting factor: Windows/FT takes about 30 minutes, and everything else normally finished before this.
But here it took about 43 and 46 minutes for the two Cirrus jobs to run. There's also a GH macos-13 in this picture, but it started almost immediately and finished after 10 mins.
And we have lots of capacity now withGH Enterprise: 50 max concurrent macOS runners:
So the speed of Cirrus doesn't matter here when we're waiting 45 mins for them to even start.