Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134322: fix the__repr__ value ofthreading.RLock from_threadmodule, when just created#134389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 5 commits intopython:mainfromYvesDup:rlock-threading-erronous-count
May 22, 2025

Conversation

YvesDup
Copy link
Contributor

@YvesDupYvesDup commentedMay 20, 2025•
edited by bedevere-appbot
Loading

When athreading.RLock is just created, the value of_count attribute is set to 1 instead of 0.
Note that__repr__ is correct when_threadmodule is inactive.

@vstinnervstinner added the needs backport to 3.14bugs and security fixes labelMay 20, 2025
@brettcannonbrettcannon removed their request for reviewMay 21, 2025 22:56
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@vstinnervstinnerenabled auto-merge (squash)May 22, 2025 16:26
@vstinnervstinner merged commitfade146 intopython:mainMay 22, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks@YvesDup for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 22, 2025
Fix the `__repr__` value of `threading.RLock` from `_thread` module, when just created.(cherry picked from commitfade146)Co-authored-by: Duprat <yduprat@gmail.com>
@bedevere-app
Copy link

GH-134528 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 22, 2025
@YvesDupYvesDup deleted the rlock-threading-erronous-count branchMay 22, 2025 16:55
vstinner pushed a commit that referenced this pull requestMay 22, 2025
gh-134322: Fix `repr(threading.RLock)` (GH-134389)Fix the `__repr__` value of `threading.RLock` from `_thread` module, when just created.(cherry picked from commitfade146)Co-authored-by: Duprat <yduprat@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@colesburycolesburycolesbury left review comments

@vstinnervstinnervstinner approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@YvesDup@vstinner@colesbury
[8]ページ先頭
©2009-2025 Movatter.jp