Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-128066: Properly handle history file writes for RO fs on PyREPL#134380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+12 −1
Merged
Changes from1 commit
Commits
Show all changes
7 commits Select commitHold shift + click to select a range
750f2be
fix: Catch OSError but don't emit a warning on failure to write history.
feoh01225ff
fix: Properly handle REPL exit for read only FS.
feoh498a430
fix: Handle append case that's run after every cmd
feoh235cd7d
Merge branch 'main' into cpatti_issue_128066
feoh00fa854
fix: Add NEWS file blurb with.. blurb :)
feoh64b1880
Merge branch 'main' into cpatti_issue_128066
feoh58fd8f4
Review nits
ambvFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
NextNext commit
fix: Catch OSError but don't emit a warning on failure to write history.
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit750f2be0e505ab1e9c7e9ff54fe2cdaee1eb9081
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.