Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-85045: clarified that the underlying buffer of a TextIOBase can be a RawIOBase#134372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

AlexKautz
Copy link
Contributor

@AlexKautzAlexKautz commentedMay 20, 2025•
edited by github-actionsbot
Loading

Added a clarification that the underlying binary buffer of a TextIOBase
can be a BufferedIOBase OR a RawIOBase.

RawIOBase was previously not specified because it is a edge case (was recently added along with non-buffered mode).

📚 Documentation preview 📚:https://cpython-previews--134372.org.readthedocs.build/

@python-cla-bot
Copy link

python-cla-botbot commentedMay 20, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

that the underlying binary buffer of a TextIOBasecan be a BufferedIOBase OR a RawIOBase
@AlexKautzAlexKautzforce-pushed the85045-io.TextIOBase.buffer-is-not-necessarily-a-buffer branch from678ebbb to169c954CompareMay 20, 2025 18:11
Copy link
Member

@gpsheadgpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks!

@gpsheadgpsheadenabled auto-merge (squash)May 20, 2025 18:14
@gpsheadgpshead added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 20, 2025
@gpsheadgpshead moved this fromTodo toIn Progress inDocs PRsMay 20, 2025
@gpsheadgpshead merged commit36eb711 intopython:mainMay 20, 2025
31 of 32 checks passed
@github-project-automationgithub-project-automationbot moved this fromIn Progress toDone inDocs PRsMay 20, 2025
@miss-islington-app
Copy link

Thanks@AlexKautz for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2025
…can be a RawIOBase (pythonGH-134372)Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase(cherry picked from commit36eb711)Co-authored-by: Alex Kautz <alex@takemobi.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2025
…can be a RawIOBase (pythonGH-134372)Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase(cherry picked from commit36eb711)Co-authored-by: Alex Kautz <alex@takemobi.com>
@bedevere-app
Copy link

GH-134374 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 20, 2025
@bedevere-app
Copy link

GH-134375 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 20, 2025
gpshead pushed a commit that referenced this pull requestMay 20, 2025
… can be a RawIOBase (GH-134372) (#134374)gh-85045: clarified that the underlying buffer of a TextIOBase can be a RawIOBase (GH-134372)Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase(cherry picked from commit36eb711)Co-authored-by: Alex Kautz <alex@takemobi.com>
gpshead pushed a commit that referenced this pull requestMay 20, 2025
… can be a RawIOBase (GH-134372) (#134375)gh-85045: clarified that the underlying buffer of a TextIOBase can be a RawIOBase (GH-134372)Added a clarification that the underlying binary buffer of a TextIOBase can be a BufferedIOBase OR a RawIOBase(cherry picked from commit36eb711)Co-authored-by: Alex Kautz <alex@takemobi.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gpsheadgpsheadgpshead approved these changes

Assignees

@gpsheadgpshead

Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@AlexKautz@gpshead
[8]ページ先頭
©2009-2025 Movatter.jp