Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-134323: Fix the newthreading.RLock.locked method#134368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 10 commits intopython:mainfromYvesDup:rlock-threading-locked-failed
May 22, 2025

Conversation

YvesDup
Copy link
Contributor

@YvesDupYvesDup commentedMay 20, 2025•
edited
Loading

This method should call the privatelocked method of_block attribute instead the private_count attribute which is reserved for counting recursive call ofacquire/release.

The fix also concerns the_thread module in therlock_locked function.

@colesburycolesbury requested a review frommpageMay 20, 2025 20:43
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

cc@sobolevn who added this locked() method.

YvesDupand others added2 commitsMay 21, 2025 18:15
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks for the multiple updates :-)

YvesDup reacted with hooray emoji
@vstinnervstinner added the needs backport to 3.14bugs and security fixes labelMay 22, 2025
@vstinnervstinnerenabled auto-merge (squash)May 22, 2025 13:45
@vstinnervstinner merged commit3effede intopython:mainMay 22, 2025
45 checks passed
@miss-islington-app
Copy link

Thanks@YvesDup for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 22, 2025
…H-134368)(cherry picked from commit3effede)Co-authored-by: Duprat <yduprat@gmail.com>Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

GH-134510 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 22, 2025
@vstinner
Copy link
Member

Merged, thanks for the fix.

YvesDup reacted with hooray emoji

vstinner pushed a commit that referenced this pull requestMay 22, 2025
) (#134510)gh-134323: Fix the new `threading.RLock.locked` method (GH-134368)(cherry picked from commit3effede)Co-authored-by: Duprat <yduprat@gmail.com>Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@YvesDup
Copy link
ContributorAuthor

LGTM. Thanks for the multiple updates :-)

Thank's all for your comments

@YvesDupYvesDup deleted the rlock-threading-locked-failed branchMay 22, 2025 16:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@colesburycolesburycolesbury left review comments

@kumaraditya303kumaraditya303kumaraditya303 left review comments

@vstinnervstinnervstinner approved these changes

@mpagempageAwaiting requested review from mpage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@YvesDup@vstinner@colesbury@kumaraditya303
[8]ページ先頭
©2009-2025 Movatter.jp