Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-134357: Remove unused imports in tests#134340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. I just have doubt about theLib/test/support/__init__.py change.
| @@ -2728,7 +2727,6 @@ def iter_builtin_types(): | |||
| # Fall back to making a best-effort guess. | |||
| if hasattr(object, '__flags__'): | |||
| # Look for any type object with the Py_TPFLAGS_STATIC_BUILTIN flag set. | |||
| import datetime | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This import has to stay. It deserves a# noqa: F401.
@encukou: Can you confirm?
Uh oh!
There was an error while loading.Please reload this page.
| ChannelError, ChannelNotFoundError, ChannelClosedError, # noqa: F401 | ||
| ChannelEmptyError, ChannelNotEmptyError, # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In this specific case maybe better to add a per-file ignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Or would you prefer the two unused imports on the same line? That way we still check the rest of the file.
| ChannelError,ChannelNotFoundError,ChannelClosedError,# noqa: F401 | |
| ChannelEmptyError,ChannelNotEmptyError,# noqa: F401 | |
| from_interpchannelsimport ( | |
| ChannelError,ChannelNotFoundError,ChannelEmptyError, | |
| ChannelClosedError,ChannelNotEmptyError,# noqa: F401 | |
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm fine with the current PR: two lines with# noqa: F401.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Like#120417 and#131152, remove unused imports in tests.
Also add lint rule (F401) to the Ruff
Lib/test/config.