Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-134208: remove dead AC directives for_curses.window.{chgat,getstr,instr}#134325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
_curses.window.{getch,getstr,instr}_curses.window.{chgat,getstr,instr}…linic-134208# Conflicts:#Modules/_cursesmodule.c
gpshead approved these changesMay 25, 2025
29e8115 intopython:main 42 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Considering#134283 has been merged back into 3.14, I'll also backport this. |
Thanks@picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
picnixz added a commit to picnixz/cpython that referenced this pull requestMay 26, 2025
….{chgat,getstr,instr}` (pythonGH-134325)(cherry picked from commit29e8115)Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>GH-134701 is a backport of this pull request to the3.14 branch. |
picnixz added a commit that referenced this pull requestMay 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This can be merged before or after#134283 since there will be conflicts to solve. Since#134283 was a sprint-dedicated issue, I think it's better not to bother new contributors so I'll hold the merge and resolve the conflicts myself later this week (it's not a pressing matter).
_cursesmodule.c#134208