Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Clean up test_posixpath#134315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:test-posixpath-cleanupMay 20, 2025
Merged
Clean up test_posixpath#134315
serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:test-posixpath-cleanupMay 20, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
serhiy-storchaka commentedMay 20, 2025
- Ensure that created files and dirs are always removed after test. Now addCleanup() does not conflict with tearDown().
- Use os_helper.unlink() and os_helper.rmdir().
- Import TESTFN from os_helper.
* Ensure that created files and dirs are always removed after test. Now addCleanup() does not conflict with tearDown().* Use os_helper.unlink() and os_helper.rmdir().* Import TESTFN from os_helper.
e29171b intopython:main 50 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2025
* Ensure that created files and dirs are always removed after test. Now addCleanup() does not conflict with tearDown().* Use os_helper.unlink() and os_helper.rmdir().* Import TESTFN from os_helper.(cherry picked from commite29171b)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2025
* Ensure that created files and dirs are always removed after test. Now addCleanup() does not conflict with tearDown().* Use os_helper.unlink() and os_helper.rmdir().* Import TESTFN from os_helper.(cherry picked from commite29171b)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-134316 is a backport of this pull request to the3.14 branch. |
GH-134317 is a backport of this pull request to the3.13 branch. |
serhiy-storchaka added a commit that referenced this pull requestMay 20, 2025
* Ensure that created files and dirs are always removed after test. Now addCleanup() does not conflict with tearDown().* Use os_helper.unlink() and os_helper.rmdir().* Import TESTFN from os_helper.(cherry picked from commite29171b)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestMay 20, 2025
* Ensure that created files and dirs are always removed after test. Now addCleanup() does not conflict with tearDown().* Use os_helper.unlink() and os_helper.rmdir().* Import TESTFN from os_helper.(cherry picked from commite29171b)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.