Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-133940: test_strftime incorrectly calculates expected week#134281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -39,7 +39,21 @@ def _update_variables(self, now): | ||||||||||||||||||||||||||||||||||
ifnow[3]<12:self.ampm='(AM|am)' | ||||||||||||||||||||||||||||||||||
else:self.ampm='(PM|pm)' | ||||||||||||||||||||||||||||||||||
jan1=time.struct_time( | ||||||||||||||||||||||||||||||||||
( | ||||||||||||||||||||||||||||||||||
now.tm_year,# Year | ||||||||||||||||||||||||||||||||||
1,# Month (January) | ||||||||||||||||||||||||||||||||||
1,# Day (1st) | ||||||||||||||||||||||||||||||||||
0,# Hour (0) | ||||||||||||||||||||||||||||||||||
0,# Minute (0) | ||||||||||||||||||||||||||||||||||
0,# Second (0) | ||||||||||||||||||||||||||||||||||
-1,# tm_wday (will be determined) | ||||||||||||||||||||||||||||||||||
1,# tm_yday (day 1 of the year) | ||||||||||||||||||||||||||||||||||
-1,# tm_isdst (let the system determine) | ||||||||||||||||||||||||||||||||||
) | ||||||||||||||||||||||||||||||||||
) | ||||||||||||||||||||||||||||||||||
# use mktime to get the correct tm_wday and tm_isdst values | ||||||||||||||||||||||||||||||||||
self.jan1=time.localtime(time.mktime(jan1)) | ||||||||||||||||||||||||||||||||||
Comment on lines +42 to +56 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
Why not just all on one line like before, it seems clear to me, and this is a test after all. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. FWIW I like the long version myself. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. IMO it is overkill and distracting, if you are looking at these tests you are probably familiar with | ||||||||||||||||||||||||||||||||||
try: | ||||||||||||||||||||||||||||||||||
ifnow[8]:self.tz=time.tzname[1] | ||||||||||||||||||||||||||||||||||
Uh oh!
There was an error while loading.Please reload this page.