Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-131178: fix SSL tests forhttp.server
command-line interface#134279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Ok, so the tests hang on macOS & Windows for some reason I'm not aware of. The tests are really more E2E tests but they can help catching possible issues so I'm keeping them. |
!buildbot ASAN |
picnixz commentedMay 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ok, since the build bots are struggling, I'll first remove the bits where we test the HTTP server. I'll try to see how we can reliably test this component later (I'm essentially applyingPEP-11 recommendations when a Tier-1 bot is failing). |
…st-131178# Conflicts:#Lib/test/test_httpservers.py
picnixz commentedMay 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Ha!
So there is something happening! I'll continue investigating this. At least, I think I know why it failed on the build bots. Presumably, the address being served was incorrectly parsed for some reason (namely it wasn't 127.0.0.1 or there was some exception being raised that I wasn't aware of) |
!buildbot ASAN |
bedevere-bot commentedMay 20, 2025
🤖 New build scheduled with the buildbot fleet by@picnixz for commitf735ee5 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134279%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
ggqlq commentedMay 23, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I tried to reproduce these problems locally based on the commit that cause the buildbot failed(commit hash605022a) and It appears that both of the Here's my reproduction of these bugs
$ git reset --hard 605022aeb69ae19cae1c020a6993ab5c433ce907$ ./configure --with-openssl=donotexist# ...$ make -j12# ...Could not build the ssl module!Python requires a OpenSSL 1.1.1 or newer$ ./python -mtest test_httpservers -v# ...======================================================================ERROR: test_http_client (test.test_httpservers.CommandLineRunTimeTestCase.test_http_client)----------------------------------------------------------------------# ...AttributeError:'NoneType' object has no attribute'create_default_context'======================================================================FAIL: test_https_client (test.test_httpservers.CommandLineRunTimeTestCase.test_https_client)----------------------------------------------------------------------# ...AssertionError: False is nottrue---------------------------------------------------------------------- |
Ah thank you! this is something I couldn't understand as I couldn't show the traceback in full. Thank you very much for that. |
Actually, there is something else. The errors were: FAIL:test_https_client (test.test_httpservers.CommandLineRunTimeTestCase.test_https_client)----------------------------------------------------------------------Traceback (mostrecentcalllast):File"/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-intel-aws.macos-with-brew.asan.nogil/build/Lib/test/test_httpservers.py",line1533,intest_https_clientself.assertTrue(self.wait_for_server(proc,'https',port,bind))~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Falseisnottrue However, I've already disabled the test if |
!buildbot x86-64 MacOS Intel |
bedevere-bot commentedMay 23, 2025
🤖 New build scheduled with the buildbot fleet by@picnixz for commit7686f3a 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134279%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Uh oh!
There was an error while loading.Please reload this page.
This is a fresh PR because I don't know why GHA is stuck. Locally it works, and I don't know why it now fails remotely.