Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-133998: Fix gzip file creation when time is out of range#134278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
adang1345 wants to merge7 commits intopython:mainChoose a base branch fromadang1345:fix-gzip-mtime
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+38 −5
Open
Changes from1 commit
Commits
Show all changes
7 commits Select commitHold shift + click to select a range
64681af
gh-133998: Fix gzip file creation when time is out of range
adang13453241cf2
📜🤖 Added by blurb_it.
blurb-it[bot]79d8a72
Remove extra newline
adang1345e701310
Address review comments regarding documentation
adang134590a881b
Keep docstring in line with documentation
adang13459638ca0
Improve error message when mtime is out of range
adang134520da98a
Re-format changelog message
adang1345File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Keep docstring in line with documentation
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit90a881b888f7939fc8d9655285b44764ef6b861f
There are no files selected for viewing
7 changes: 5 additions & 2 deletionsLib/gzip.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -188,8 +188,11 @@ def __init__(self, filename=None, mode=None, | ||
The optional mtime argument is the timestamp requested by gzip. The time | ||
is in Unix format, i.e., seconds since 00:00:00 UTC, January 1, 1970. | ||
Set mtime to 0 to generate a compressed stream that does not depend on | ||
creation time. If mtime is omitted or None, the current time is used; | ||
however, if the current time is outside the range 00:00:00 UTC, January | ||
1, 1970 through 06:28:15 UTC, February 7, 2106, then the value 0 is used | ||
instead. | ||
Comment on lines +191 to +195 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Ditto, see previous comment | ||
""" | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.