Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-133998: Fix gzip file creation when time is out of range#134278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| creation time. If *mtime* is omitted or ``None``, the current time is used; | ||
| however, if the current time is outside the range 00:00:00 UTC, January 1, | ||
| 1970 through 06:28:15 UTC, February 7, 2106, then the value ``0`` is used | ||
| instead. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The docs are slightly wrong now thatGzipFile.__init__ will raise a ValueError if the specified value is out of range.
I know you've documented it in the docstring for__init__, but I think it's worth clarifying here since we're already in the area.
| Set mtime to 0 to generate a compressed stream that does not depend on | ||
| creation time. If mtime is omitted or None, the current time is used; | ||
| however, if the current time is outside the range 00:00:00 UTC, January | ||
| 1, 1970 through 06:28:15 UTC, February 7, 2106, then the value 0 is used | ||
| instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ditto, see previous comment
| @@ -0,0 +1 @@ | |||
| Fix ``struct.error`` exception when creating a file with ``gzip.GzipFile()`` if the system time is outside the range 00:00:00 UTC, January 1, 1970 through 06:28:15 UTC, February 7, 2106. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this should also be tweaked since the behaviour of providing an out-of-rangemtime has changed
Uh oh!
There was an error while loading.Please reload this page.
If the system clock is set so that
time.time()falls outside of the range0through2**32-1, then creation of a GZIP-compressed file usinggzip.GzipFile()would fail with the exceptionstruct.error: 'L' format requires 0 <= number <= 4294967295. Fix this error.If the
mtimeargument togzip.GzipFile()is explicitly set to an out-of-range value, then the behavior is unchanged, and we continue raising the exception.2106-02-07T06:28:15#133998📚 Documentation preview 📚:https://cpython-previews--134278.org.readthedocs.build/